• fix: correcting resource id names #208
• feat: fixing transaction schema #207 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

feat(api): add type discriminators to transactions, union response types for operations

openapi

fix(types): add discriminated union to transfer-in/transfer-out/transactions responses

python

fix(types): update return types in transfer_in/transfer_out/transactions

typescript

feat(api): add response types to transferIn/transferOut/transactions methods

Edit this comment to update them. They will appear in their respective SDK's changelogs.

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-19 22:01:01 UTC

Greptile Summary

This PR refactors transaction schema inheritance to properly handle polymorphic types using OpenAPI's oneOf discriminator pattern. The key changes include:

• Created TransactionOneOf schema that uses oneOf discriminator to distinguish between IncomingTransaction and OutgoingTransaction
• Added explicit type property with specific enum values (INCOMING/OUTGOING) to both transaction type schemas
• Updated all API endpoints to reference TransactionOneOf instead of base Transaction schema
• Added stainless config to remove type property from base Transaction schema to prevent allOf merge conflicts
• Removed paymentInstructions from required fields in OutgoingTransaction (already flagged in previous review)

The refactoring improves OpenAPI schema validation and documentation clarity by properly implementing discriminated unions, though it does add a layer of indirection (TransactionOneOf → transaction types → base Transaction).

Confidence Score: 4/5

• Safe to merge with minor caveats - schema refactoring is sound but has one already-flagged concern
• The schema refactoring correctly implements OpenAPI polymorphism patterns and the stainless config appropriately handles type conflicts. However, the removal of paymentInstructions from required fields in OutgoingTransaction was already flagged in a previous review and remains unaddressed, which could be a breaking change for existing clients
• Pay attention to openapi/components/schemas/transactions/OutgoingTransaction.yaml - the removal of paymentInstructions from required fields needs verification

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class Transaction {
        +string id
        +TransactionStatus status
        +string type
        +TransactionDestinationOneOf destination
        +string customerId
        +string platformCustomerId
        +datetime settledAt
        +datetime createdAt
        +datetime updatedAt
        +string description
    }
    
    class TransactionOneOf {
        <<oneOf>>
        discriminator: type
    }
    
    class IncomingTransaction {
        +string type = "INCOMING"
        +CurrencyAmount receivedAmount
        +TransactionSourceOneOf source
        +ReconciliationInstructions reconciliationInstructions
        +IncomingRateDetails rateDetails
        +IncomingTransactionFailureReason failureReason
    }
    
    class OutgoingTransaction {
        +string type = "OUTGOING"
        +CurrencyAmount sentAmount
        +CurrencyAmount receivedAmount
        +TransactionSourceOneOf source
        +number exchangeRate
        +int64 fees
        +string quoteId
        +PaymentInstructions[] paymentInstructions
        +Refund refund
        +OutgoingRateDetails rateDetails
        +OutgoingTransactionFailureReason failureReason
    }
    
    Transaction <|-- IncomingTransaction : extends via allOf
    Transaction <|-- OutgoingTransaction : extends via allOf
    TransactionOneOf *-- IncomingTransaction : discriminates
    TransactionOneOf *-- OutgoingTransaction : discriminates
    
    note for TransactionOneOf "API endpoints now reference\nTransactionOneOf instead of\nTransaction base schema"
    note for IncomingTransaction "type property added\nto required fields"
    note for OutgoingTransaction "type property added;\npaymentInstructions removed\nfrom required fields"

_{Last reviewed commit: 8ad3ce8}